fix(expenses): add fetch_categories tool and category field to add-expense form - #9
Merged
Merged
Conversation
…pense form - Add fetch_categories read-only WebMCP tool contract and implementation - Update submit_expense tool contract to accept categoryId UUID instead of category name - Add category dropdown selector to Add Expense form with declarative annotations - Update unit tests and tool registration assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
submit_expense, its schema previously accepted acategoryproperty (name string like"Travel"), but the backend'sCreateExpenseDtoexpectscategoryId(UUID) withValidationPipe({ whitelist: true, forbidNonWhitelisted: true }). This caused a 400 Bad Request error whencategorywas passed, and recent entries lacked acategory_idin the database.Solution
fetch_categoriesTool:FETCH_CATEGORIES) in@actuo/sharedand implemented inExpenseTools.id,name,icon) so the model can resolve human-readable category names to validcategoryIdUUIDs before filing.ALWAYS_ON_TOOLS.submit_expenseTool Contract:categoryIdUUID, aligned directly with backendCreateExpenseDto.fetch_categoriesfirst when a user mentions a category.<select id="categoryId" name="categoryId">dropdown populated asynchronously fromGET /api/orgs/current/categories.categoryIdin the creation payload.fetch_categoriesandcategoryIdsubmission inexpense-tools.spec.ts.add-expense.spec.ts.gemini-schema.spec.tsandtool-session.spec.ts.Verification
pnpm build): passed